[5.3] Added support for PhpRedis #14850

tillkruss · 2016-08-16T17:31:12Z

Followup from laravel/docs#2500 to add PhpRedis support to Laravel, because it's significatly faster than Predis.

This is a proof of concept. Feedback/suggestions are greatly appreciated.

Illuminate\Redis\Database is now an abstract class.
PredisDatabase and PhpRedisDatabase were introduced, extending Illuminate\Redis\Database
Laravel uses Illuminate\Contracts\Redis\Database instead of Illuminate\Redis\Database in most places.
Illuminate/Cache/RedisStore and Illuminate/Cache/Repository now check key existence using null or false.
Laravel will use Predis as default unless the config value database.redis.client is set to phpredis.
Predis connection parameters are mapped to the slightly different Redis and RedisCluster parameters.

A few things are still unfinished:

New tests for PhpRedis
Redis Facade when using PhpRedis
Alias for redis in src/Illuminate/Foundation/Application.php

GrahamCampbell · 2016-08-16T17:41:47Z

Doesn't the redis php library already use that extention if it's present?

tillkruss · 2016-08-16T17:45:22Z

Predis doesn't fallback to PhpRedis.

taylorotwell · 2016-08-16T18:41:49Z

Oh. This was a lot more involved than I thought.

GrahamCampbell · 2016-08-16T20:24:28Z

Redis Facade when using PhpRedis

Why do we need two facades?

tillkruss · 2016-08-16T20:47:23Z

What I meant by that is, that we need to make sure that Redis facade is working when using PhpRedis.

taylorotwell · 2016-08-18T13:49:14Z

Looks like a decent start and the performance gains would probably be nice for people who use Redis heavily.

GrahamCampbell · 2016-08-18T13:52:37Z

Why not contribute this driver to the other project so everyone benefits?

tillkruss · 2016-08-18T14:09:36Z

@taylorotwell Great, I'll test, improve and finish this up today.

@GrahamCampbell: Other project?

GrahamCampbell · 2016-08-18T14:14:33Z

The PHP library we're using which already supports one of the native redis extensions.

tillkruss · 2016-08-18T14:16:18Z

@GrahamCampbell Do you have a link for more information on that?

GrahamCampbell · 2016-08-18T14:17:38Z

https://github.com/nrk/predis/tree/v1.1/src/Connection

GrahamCampbell · 2016-08-18T14:18:07Z

Also, right at the start of their readme:

Predis does not require any additional C extension by default, but it can be optionally paired with phpiredis to lower the overhead of the serialization and parsing of the Redis RESP Protocol.

:P

tillkruss · 2016-08-18T16:44:10Z

@taylorotwell

I've added separate subscribe() and psubscribe() methods for Predis and PhpRedis.

The client key is now pulled from the config in the RedisServiceProvider.

I've pointed the core alias for redis to the abstract Illuminate\Redis\Database class. I'm not sure if that's correct, or if we need a Redis Database Manager or similar.

tillkruss · 2016-08-18T16:47:57Z

To test/use this:

Rename (or uncomment) Redis facade in config/app.php.
Add 'client' => 'phpredis', to redis array in config/database.php.

GrahamCampbell · 2016-08-30T14:55:27Z

Please rebase. :)

GrahamCampbell · 2016-08-30T14:55:35Z

Without merge commits please.

)

* Add missing methods * fix docblock

Export phpunit.xml.dist instead of phpunit.xml.

Update the author email address to taylor@laravel.com instead of gmail.

…led to add view namespace (laravel#14817)

* Add withoutTrashed method to SoftDeletingScope * Apply StyleCI patch

)

* Change read to timestamp from boolean * Use timestamps not datetime * Dont use carbon, instead use freshTimstamp() * Use read_at not read

tillkruss · 2016-08-30T16:06:07Z

@GrahamCampbell I messed up the branch and reopened another PR.

GrahamCampbell changed the title ~~Added support for PhpRedis~~ [5.3] Added support for PhpRedis Aug 16, 2016

taylorotwell force-pushed the 5.3 branch from 465e403 to 7d116dc Compare August 23, 2016 15:14

tillkruss force-pushed the phpredis branch 2 times, most recently from 911f8fb to 4359ffe Compare August 30, 2016 15:25

flugg and others added 10 commits August 30, 2016 08:25

Add relation not found exception

ef20f4b

Fix styling

1028ba3

Remove old suggested dependency from support (laravel#14490)

b67e606

Fix a docblock (laravel#14489)

6722e39

remove the morphclass (laravel#14477)

6786748

pass notifiable

44895e6

break down multi lines into single lines on a single line call.

33be832

fleunt set the notification level

0d2bc55

fluent set the subject

c3169c9

fix build order

a16dd5b

eriktisme and others added 23 commits August 30, 2016 08:28

Remove import of a class which doesn't exist. (laravel#14807)

b2c324a

Use KEYS only for redis keys and ARGV for other arguments (laravel#14802

80027fb

)

[5.3] Add missing methods (laravel#14800)

2d2bf92

* Add missing methods * fix docblock

working on methods

efe8426

Fix export-ignore for phpunit.xml

bc50722

Export phpunit.xml.dist instead of phpunit.xml.

Update author email

209ab57

Update the author email address to taylor@laravel.com instead of gmail.

Protect against empty paths in the view:clear command (laravel#14812)

ef0d3f2

Load NotificationServiceProvider eagerly because boot needs to be cal…

29084a8

…led to add view namespace (laravel#14817)

Fix getRouteForMethods docblock (laravel#14823)

a43a9d1

Fix ResourceRegistrar docblock (laravel#14822)

e0ed7ec

Remove nitpick (laravel#14821)

e871b29

Sort require (laravel#14820)

3f7d05b

add sync without detaching method

43335bc

[5.2] Add withoutTrashed method to SoftDeletingScope (laravel#14805)

9ee4098

* Add withoutTrashed method to SoftDeletingScope * Apply StyleCI patch

change method order

e44f140

Fire events on channel level and add event before sending (laravel#14804

4c0e72e

)

fix order

0d33945

fix method order

5350557

[5.3] Change read to timestamp from boolean (laravel#14797)

8de7d6f

* Change read to timestamp from boolean * Use timestamps not datetime * Dont use carbon, instead use freshTimstamp() * Use read_at not read

check for method

8bc8df3

add more expressive helper for app

ee959a8

Only mark read_at if not already set (laravel#14840)

4eee050

Add the great macroable to Lang (laravel#14844)

6cdef4b

tillkruss force-pushed the phpredis branch 2 times, most recently from 8ee8052 to 6cdef4b Compare August 30, 2016 15:32

Added Support for PhpRedis

25ce084

tillkruss closed this Aug 30, 2016

tillkruss deleted the phpredis branch August 30, 2016 15:55

tillkruss mentioned this pull request Aug 30, 2016

[5.4] Add support for PhpRedis #15160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.3] Added support for PhpRedis #14850

[5.3] Added support for PhpRedis #14850

tillkruss commented Aug 16, 2016 •

edited

Loading

GrahamCampbell commented Aug 16, 2016

tillkruss commented Aug 16, 2016

taylorotwell commented Aug 16, 2016

GrahamCampbell commented Aug 16, 2016

tillkruss commented Aug 16, 2016

taylorotwell commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

tillkruss commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

tillkruss commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

tillkruss commented Aug 18, 2016 •

edited

Loading

tillkruss commented Aug 18, 2016

GrahamCampbell commented Aug 30, 2016

GrahamCampbell commented Aug 30, 2016

tillkruss commented Aug 30, 2016

[5.3] Added support for PhpRedis #14850

[5.3] Added support for PhpRedis #14850

Conversation

tillkruss commented Aug 16, 2016 • edited Loading

GrahamCampbell commented Aug 16, 2016

tillkruss commented Aug 16, 2016

taylorotwell commented Aug 16, 2016

GrahamCampbell commented Aug 16, 2016

tillkruss commented Aug 16, 2016

taylorotwell commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

tillkruss commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

tillkruss commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

GrahamCampbell commented Aug 18, 2016

tillkruss commented Aug 18, 2016 • edited Loading

tillkruss commented Aug 18, 2016

GrahamCampbell commented Aug 30, 2016

GrahamCampbell commented Aug 30, 2016

tillkruss commented Aug 30, 2016

tillkruss commented Aug 16, 2016 •

edited

Loading

tillkruss commented Aug 18, 2016 •

edited

Loading